issue410: Meta key doesn't work with xulrunner-13

Priority: bug Status: resolved
Files
File name Uploaded Type Edit Remove
firefox-13-fix-meta-key.patch joshe, 2012-06-25.04:43:21 application/octet-stream
Messages
msg1042 (view) Author: hgb Date: 2012-06-19.20:49:42
After an upgrade to Fedora 17, I now have xulrunner-13, and conkeror up-to-date as of 2012-06-19.  The
meta key works elsewhere, but is seemingly completely undetected in conkeror.

[20:51:15][hgb@morag:~]3 xulrunner --version
Mozilla XULRunner 13.0 - 20120605112244
msg1043 (view) Author: hgb Date: 2012-06-20.12:24:48
I use xulrunner 12.0 at work with the same conkeror code and Fedora 17 (so I'll need to hold upgrading
there...), and everything works nicely.
msg1044 (view) Author: joshe Date: 2012-06-24.04:00:06
I see this both with firefox -app on OpenBSD and xulrunner on Arch Linux. Nothing has change in my X or
conkeror configuration recently, and the meta key continues to work in emacs and xterm.

$ uname -a
OpenBSD jet 5.2 GENERIC.MP#326 amd64
$ firefox --version
Mozilla Firefox 13.0.1

$ uname -a
Linux shale 3.3.8-1-ARCH #1 SMP PREEMPT Tue Jun 5 15:20:32 CEST 2012 x86_64 GNU/Linux
$ xulrunner --version
Mozilla XULRunner 13.0 - 20120606114039
msg1045 (view) Author: joshe Date: 2012-06-24.04:03:50
This bugzilla bug would seem to be relevant. Perhaps a workaround can be implemented in conkeror:

https://bugzilla.mozilla.org/show_bug.cgi?id=751749
msg1046 (view) Author: joshe Date: 2012-06-25.04:43:21
It looks like this bug will be addressed upstream in some form in a future firefox/xulrunner version.

In the meantime, I'm just going to turn patch my firefox 13 to re-enable the meta key. Attached is the
trivial patch I'm using if anyone else wants to do the same.
msg1101 (view) Author: ubolonton Date: 2013-01-30.11:26:10
It seems recent xulrunner versions treat the windows logo key as os key instead of meta key like before.

I'm using this patch to be able to use that key:

https://github.com/ubolonton/conkeror/commit/79cbf379fccbb65c63a7debdab1e7dca110e67d0.patch
msg1119 (view) Author: hgb Date: 2013-02-14.17:48:13
Doesn't seem to fix the problem for me on fedora 18 (xulrunner-18.0.2).
msg1121 (view) Author: retroj Date: 2013-02-14.23:36:51
Ubontolon's patch does not appear to directly address the issue of
conkeror's meta key not working.  It doesn't do anything to the definition
of the "M" modifier.  It adds a new "s" modifier.

We should have a discussion about what is the best thing to do - add a new
"s" modifier, alter the existing "M" modifier in some way, or both.
msg1122 (view) Author: retroj Date: 2013-02-15.00:11:11
hgb: does it solve the problem for you if you apply ubuntolon's patch, and
put the following in your rc?

  modifiers.M = modifiers.s;
msg1123 (view) Author: hgb Date: 2013-02-15.07:50:14
Doesn't help.  It now says 'meta is undefined'.
msg1124 (view) Author: retroj Date: 2013-02-15.15:00:17
Reporting here the result of our conversation on irc.  The solution was to
put the following in the rc:
 
  modifiers.M = new modifier(
      function (event) { return event.metaKey; },
      function (event) { event.metaKey = true; });
msg1126 (view) Author: retroj Date: 2013-02-16.00:51:35
I started a new ticket to talk about 'osKey' support, since that wasn't the real issue with this one.

http://bugs.conkeror.org/issue443

Marking this issue resolved.
History
Date User Action Args
2013-02-16 00:51:35retrojsetstatus: chatting -> resolved
messages: + msg1126
2013-02-15 15:00:18retrojsetmessages: + msg1124
2013-02-15 07:50:15hgbsetmessages: + msg1123
2013-02-15 00:11:11retrojsetmessages: + msg1122
2013-02-14 23:37:14retrojsetpriority: wish -> bug
2013-02-14 23:36:51retrojsetmessages: + msg1121
2013-02-14 17:48:13hgbsetmessages: + msg1119
2013-01-30 11:26:11ubolontonsetpriority: bug -> wish
messages: + msg1101
2012-06-25 04:43:21joshesetfiles: + firefox-13-fix-meta-key.patch
messages: + msg1046
2012-06-24 04:03:50joshesetmessages: + msg1045
2012-06-24 04:00:06joshesetmessages: + msg1044
2012-06-20 12:24:48hgbsetstatus: unread -> chatting
messages: + msg1043
2012-06-19 20:49:42hgbcreate