issue77: Minibuffer completion inserts space when completing in the middle of text

Priority: bug Status: in-progress
msg132 (view) Author: drdo Date: 2008-11-29.03:46:06
Steps to reproduce:

1. Save a file
2. (When selecting the path) Set the cursor in the middle of the text
3. Try completing something
msg498 (view) Author: retroj Date: 2009-11-09.17:47:40
msg549 (view) Author: fjl Date: 2010-02-11.23:15:14
If there is interest in changing this behaviour, please pull from git://
msg550 (view) Author: retroj Date: 2010-02-12.00:04:37
thanks fjl, but... although the original report is not incredibly clear
about this, the issue is actually that get_partial_completion_input_state
inserts the *wrong* separator, not that it should not insert a separator
at all.  for most of the callers of get_partial_completion_input_state, a
space is the appropriate separator, for example, when completing on the
name of a webjump.  but when completing on a file path, one would expect
it to insert the appropriate path component separator (\ or /) depending
on the OS.  if i recall correctly from the last time i was reading through
this part of conkeror, my determination was that we needed a completer
which was aware of the file system structure, in that it could tell the
difference between a file and a directory, insert appropriate separators,
display appropriate error messages, etc, but that to implement such a
completer without huge redundancy, the system will need a little bit of
msg551 (view) Author: retroj Date: 2010-02-12.17:59:53
to put it succinctly, it's not that prefix_completer does the wrong thing, it's that prefix_completer
is the wrong tool for the job, and it's just a stand-in until we have a proper file-path completer.
msg554 (view) Author: fjl Date: 2010-02-13.14:38:17
You're right about that and i was just being naïve. 

Emacs' default prefix completion simply uses all available 
input for completion and jumps to the end of the line.
It also says "No Match" if the input isn't the prefix of an existing file or directory.

While this is a terrible solution for completing the name of a new file (i.e. when saving something)
this may be a better alternative than inserting a space. 

I'll open a new branch and implement that.
msg1174 (view) Author: retroj Date: 2013-12-20.04:05:16
This will be dealt with in the refactoring-completers branch, and resolved when that branch is merged.
Date User Action Args
2013-12-20 04:05:16retrojsetstatus: chatting -> in-progress
messages: + msg1174
2010-02-13 14:38:17fjlsetmessages: + msg554
2010-02-12 17:59:53retrojsetmessages: + msg551
2010-02-12 00:04:37retrojsetmessages: + msg550
2010-02-11 23:15:14fjlsetmessages: + msg549
2009-11-09 17:47:40retrojsetstatus: unread -> chatting
messages: + msg498
2008-11-29 03:46:06drdocreate