issue498: SpiderMonkey no longer supports let expressions

Priority: urgent Status: resolved
Files
File name Uploaded Type Edit Remove
conk-let.patch donio, 2015-12-28.18:43:25 text/x-diff
Messages
msg1277 (view) Author: donio Date: 2015-12-28.18:43:25
With https://bugzilla.mozilla.org/show_bug.cgi?id=1023609 mozilla has removed let expression/block
support. This prevents conkeror from starting up with current gecko-dev head. Attached patch converts the
instances I found to normal let statements.
msg1284 (view) Author: scottjad Date: 2016-01-15.03:56:29
Thank you dunio for this patch!

Do you know if applying this patch (and using the new let syntax) would break Conkeror on older versions
of gecko that don't use the new let syntax?

Is it the case that there's no way to support both the old and new versions of gecko without removing all
let expressions?
msg1285 (view) Author: scottjad Date: 2016-01-15.04:15:25
Sorry about misspelling donio.

Issue that removes let blocks:
https://bugzilla.mozilla.org/show_bug.cgi?id=1167029

Description of differences between old and new let:
https://blog.mozilla.org/addons/2015/10/14/breaking-changes-let-const-firefox-nightly-44/

Looks like const will need to be updated as well.

Perhaps rewriting the let uses to not use let would be best.
msg1290 (view) Author: XTaran Date: 2016-01-30.02:10:29
Fixed in commit 631644f5c4a6bc544312603eab8ae4deed0f125e. Thanks for the analysis and patch!

Please open a new issue in case this patch causes any regressions.
History
Date User Action Args
2016-01-30 02:10:52XTaransetstatus: chatting -> resolved
2016-01-30 02:10:29XTaransetmessages: + msg1290
2016-01-30 01:52:41XTaransetpriority: bug -> urgent
2016-01-15 04:15:25scottjadsetmessages: + msg1285
2016-01-15 03:56:29scottjadsetstatus: unread -> chatting
messages: + msg1284
2015-12-28 18:43:26doniocreate