issue487: Firefox 36: saveURI parameter change

Priority: bug Status: resolved
Files
File name Uploaded Type Edit Remove
0001-Fix-saveURI-aReferrerPolicy-argument-added.patch scottjad, 2015-05-01.21:56:19 text/x-patch
Messages
msg1250 (view) Author: lompik Date: 2015-03-01.02:06:47
Firefox 36: view_source does not work anymore due to change in saveURI change :
https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIWebBrowserPersist#saveURI()


(I pass 0 as the missing argument and it works but it's not clean fix :()


  Category: CSS Loader
NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIWebBrowserPersist.saveURI]
save_uri()@chrome://conkeror/content/save.js:80
download_as_temporary()@chrome://conkeror/content/save.js:266
browser_object_view_source()@chrome://conkeror/content/element.js:630
InterpretGeneratorResume()@self-hosted:657
next()@self-hosted:615
_co_impl__send()@chrome://conkeror/content/coroutine.js:415
co_call()@chrome://conkeror/content/coroutine.js:561
input_handle_keypress()@chrome://conkeror/content/input.js:303
null()@null:0
msg1254 (view) Author: quantum Date: 2015-03-09.17:08:42
I guess my problem has the same reason. I changed to iceweasel 36 (36.0.1-1~bpo70+1). Now, if I want to
save the download window apears, but there is no download progress. In the console I get:

NS_ERROR_XPC_NOT_ENOUGH_ARGS: Not enough arguments [nsIWebBrowserPersist.saveURI]
save_uri()@chrome://conkeror/content/save.js:80
null()@chrome://conkeror/content/commands.js:486
InterpretGeneratorResume()@self-hosted:657
next()@self-hosted:615
_co_impl__send()@chrome://conkeror/content/coroutine.js:415
Handler.prototype.process()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:870
this.PromiseWalker.walkerLoop()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:749
this.PromiseWalker.scheduleWalkerLoop/<()@resource://gre/modules/Promise.jsm ->
resource://gre/modules/Promise-backend.js:691
null()@null:0
msg1262 (view) Author: scottjad Date: 2015-05-01.21:56:19
Here is a fix that is backwards compatible.
msg1263 (view) Author: scottjad Date: 2015-05-10.13:21:29
Fixed in master.
History
Date User Action Args
2015-07-26 19:34:52scottjadsetstatus: chatting -> resolved
2015-05-10 13:21:29scottjadsetmessages: + msg1263
2015-05-01 21:56:19scottjadsetfiles: + 0001-Fix-saveURI-aReferrerPolicy-argument-added.patch
messages: + msg1262
2015-03-09 17:08:43quantumsetstatus: unread -> chatting
messages: + msg1254
2015-03-01 02:06:47lompikcreate